feat(auth): Add recaptcha and sms toll fraud support for phone auth #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragatimodi
changed the title
pragatimodi
changed the title
pashanka
reviewed
Aug 19, 2024
src/auth/auth-config.ts
Outdated
| */ | ||
| export interface RecaptchaTollFraudManagedRule { | ||
| /** | ||
| * The action will be enforced if the reCAPTCHA score of a request is larger than endScore. |
There was a problem hiding this comment.
Should it be startScore instead of endScore in the doc? Also should we mention the range of values that is allowed and add that into our validation logic?
Xiaoshouzi-gh
approved these changes
Sep 5, 2024
| useAccountDefender?: boolean; | ||
| useSmsBotScore?: boolean; | ||
| useSmsTollFraudProtection?: boolean; | ||
| tollFraudManagedRules?: RecaptchaTollFraudManagedRule[]; |
There was a problem hiding this comment.
is this a discrepancy between rpc request and response field?
There was a problem hiding this comment.
Yes, the rpc request address the field as tollFraudManagedRules and SDK exposes it as smsTollFraudManagedRules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.