Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated error messaging for auth-api-request.getAccountInfoByFederatedUid() #2305

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

remziz4
Copy link

@remziz4 remziz4 commented Sep 15, 2023

The previous error handling for the getAccountInfoByFederatedUid() method was misleading. In scenarios where the providerId was valid, but the uid was missing or invalid, the system would still return a "invalid-provider-id" error code. Now, the appropriate error code will be returned depending on which validation is failing.

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

…dUid()

The previous error handling for the getAccountInfoByFederatedUid() method was misleading. In scenarios where the providerId was valid, but the uid was missing or invalid, the system would still return a "invalid-provider-id" error code. Now, the appropriate error code will be returned depending on which validation is failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant