finos/a11y-theme-builder#903:that lists are structured correctly (ul) #929
Conversation
✅ Deploy Preview for glistening-gecko-6b417a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
I have no problem with the code, but it only seems to fix the "div being inside the list" issue. The list still has an accessibility issue according to Accessibility Insights because of the "role=button" that is on the list items. I found something that might help: mui/material-ui#19469 (comment). It might be worth checking out.
| "@typescript-eslint/eslint-plugin": "^7.8.0", | ||
| "@typescript-eslint/parser": "^7.8.0", | ||
| "ajv": "^7.2.4", | ||
| "eslint": "^8.57.0", |
There was a problem hiding this comment.
Do you need these changes to build? Or did you need them for linting? If just for linting, I'd move this to your linting patch.
There was a problem hiding this comment.
ajv need for build its shows me error when i tired to build
There was a problem hiding this comment.
don't commit the themes file, please. I personally usually do this when I'm creating a commit:
# check to see which files have changed
git status
# check to see that file changes are only those that I'm expecting and that I haven't left in any extraneous
# code that I commented out or test code or extraneous logging
git diff code/src/ui/src/pages/WelcomePage.tsx code/src/ui/src/components/LeftNavTabs.tsx
# add the code files individually (by just changing git diff to git add in the previous command)
# so that I know that I'm only committing code that I mean to
git add code/src/ui/src/pages/WelcomePage.tsx code/src/ui/src/components/LeftNavTabs.tsx
Doing something like git add . sometimes grabs too much stuff.
There was a problem hiding this comment.
okay i will take care of that
how you are producing this error ,i am checking through its gives me no error see this |
|
@ShadabImran07 try this:
The menu items in the left nav bar under "General Desktop" (like Avatar, Buttons, Cards) seem to be buttons that have the role="button" attribute. Let me know if that doesn't show errors in Accessibility Insights. Thanks! |
|
@aaronreed708 ya i can see that ,I have tried only in hompage that why its not showing the error. |
Corrected the changes @aaronreed708 you have asked regarding issue 903