This repository has been archived by the owner on May 15, 2024. It is now read-only.
Signal content length to upstream components when present #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the HTTP request contains `Content-Length` header, include it in
the body reader passed down to upstream system components. This is to
enable further optimisations during processing when the total size of a
blob is known beforehand. Examples include piece selection in order to
guarantee that a blob will be fully contained within a piece.
With changes introduced, an upstream component may type-check for
`interface { Size() int64}` and use it to then gain access to the
content length.
Note that based on HTTP standards, `application/octet-stream` content
type is not strictly required to specify `Content-Length` header. Hence
the opportunistic signalling via type-checkers.
The Azure mirrors seem to be intermittently unavailable. This causes build failure during CI setup steps while installing C libraries required by filecoin-ffi. To mitigate the issue, explicitly run `apt-get update` to get the list of latest package mirrors.
willscott
approved these changes
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the HTTP request contains
Content-Lengthheader, include it in the body reader passed down to upstream system components. This is to enable further optimisations during processing when the total size of a blob is known beforehand. Examples include piece selection in order to guarantee that a blob will be fully contained within a piece.With changes introduced, an upstream component may type-check for
interface { Size() int64 }and use it to then gain access to the content length.Note that based on HTTP standards,
application/octet-streamcontent type is not strictly required to specifyContent-Lengthheader. Hence the opportunistic signalling via type-checkers.