This repository has been archived by the owner on May 15, 2024. It is now read-only.
Extend blob store to return status and handle /status #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the blob store interface to separate `Describe` from `Get`, and
extend the content of `blob.Descriptor` to include `blob.Status`.
Reflect the changes on the existing stores. Leave TODOs in place for the
actual information fetching of the deals made by the store to be
implemented in separate PRs.
Change the sever to correctly handle `GET /v0/blob/{id}/status`.
willscott
approved these changes
Jul 21, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the blob store interface to separate
DescribefromGet, and extend the content ofblob.Descriptorto includeblob.Status.Reflect the changes on the existing stores. Leave TODOs in place for the actual information fetching of the deals made by the store to be implemented in separate PRs.
Change the sever to correctly handle
GET /v0/blob/{id}/status.