Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Add health check to Singularity API #164

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

xinaxu
Copy link
Collaborator

@xinaxu xinaxu commented Oct 17, 2023

This resolves #155

  • This will consume the new Singularity version v0.5.2 which needs to wait for below
  • Modified docker-compose-local-dev.yml
    • Removed abundant overrides
  • Added docker-compose-local-dev-with-singularity.yml
    • This will work with a locally cloned Singularity repo
  • Updated compose file in integration test
  • Updated Github action to use the correct path of filecoin-proof-parameters

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Merging #164 (27933a5) into main (01d6702) will decrease coverage by 0.68%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   31.49%   30.82%   -0.68%     
==========================================
  Files           5        5              
  Lines         743      743              
==========================================
- Hits          234      229       -5     
- Misses        474      479       +5     
  Partials       35       35              

see 1 file with indirect coverage changes

Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to also add a section in README


networks:
default:
name: motion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this file is added as as extension? I am curious why not update the docker compose it extends directly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the networks section cannot be extended. extension only works for service

@xinaxu xinaxu merged commit 7230d07 into main Oct 17, 2023
7 checks passed
@xinaxu xinaxu deleted the xinaxu/singularity-api-health-check branch October 17, 2023 23:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no healthcheck error when running motion in docker compose
3 participants