This repository has been archived by the owner on May 15, 2024. It is now read-only.
feat: update schedule #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijaharita
force-pushed
the
feat/update-schedule
branch
from
3dcce90
to
4bddd60
Compare
hannahhoward
approved these changes
Sep 15, 2023
integration/singularity/store.go
Outdated
| if foundSchedule != nil { | ||
| // If schedule was found, update it | ||
| logger.Infow("Schedule found for provider. Updating with latest settings...", "id", foundSchedule.ID) | ||
| l.singularityClient.DealSchedule.UpdateSchedule(&deal_schedule.UpdateScheduleParams{ |
There was a problem hiding this comment.
You should check for an error no?
There was a problem hiding this comment.
ah, good catch, thanks!
is there no lint for that?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update singularity schedules on startup in case settings have changed. branched from #110
closes #114