Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

no healthcheck error when running motion in docker compose #155

Closed
masih opened this issue Oct 11, 2023 · 8 comments · Fixed by #164
Closed

no healthcheck error when running motion in docker compose #155

masih opened this issue Oct 11, 2023 · 8 comments · Fixed by #164
Assignees
@xinaxu
Labels
bug Something isn't working P1

Comments

@masih
Copy link
Member

masih commented Oct 11, 2023

Reported by @Angelo-gh3990

[+] Running 7/0
 ⠿ Container motion-db-1                            Running                                                                                                                                                                                                                             0.0s
 ⠿ Container motion-singularity_admin_init-1        Created                                                                                                                                                                                                                             0.0s
 ⠿ Container motion-singularity_deal_tracker-1      Running                                                                                                                                                                                                                             0.0s
 ⠿ Container motion-singularity_deal_pusher-1       Running                                                                                                                                                                                                                             0.0s
 ⠿ Container motion-singularity_api-1               Running                                                                                                                                                                                                                             0.0s
 ⠿ Container motion-singularity_dataset_worker-1    Running                                                                                                                                                                                                                             0.0s
 ⠿ Container motion-singularity_content_provider-1  Running                                                                                                                                                                                                                             0.0s
Attaching to motion-db-1, motion-motion-1, motion-singularity_admin_init-1, motion-singularity_api-1, motion-singularity_content_provider-1, motion-singularity_dataset_worker-1, motion-singularity_deal_pusher-1, motion-singularity_deal_tracker-1
motion-singularity_admin_init-1        | 2023-10-11T18:28:20.399Z       INFO    database        database/connstring_cgo.go:35   Opening postgres database
motion-singularity_admin_init-1        | 2023-10-11T18:28:20.408Z       INFO    model   model/migrate.go:51     Auto migrating tables
motion-singularity_admin_init-1 exited with code 0
dependency failed to start: container for service "singularity_api" has no healthcheck configured
@masih masih added the bug Something isn't working label Oct 11, 2023
@Angelo-gh3990
Copy link
Contributor

Running Ubuntu 20.04 TLS
Kernel: Linux 5.4.0-135-generic #152-Ubuntu SMP
Docker: Docker version 24.0.6, build ed223bc
Docker compose: Docker Compose version v2.21.0

git clone https://github.com/filecoin-project/motion.git

cp ./.env.example .env
edit .env

docker compose up

[+] Running 7/0
 ✔ Container motion-db-1                            Running                                                                                                                                                                                                                             0.0s
 ✔ Container motion-singularity_admin_init-1        Created                                                                                                                                                                                                                             0.0s
 ✔ Container motion-singularity_deal_tracker-1      Running                                                                                                                                                                                                                             0.0s
 ✔ Container motion-singularity_deal_pusher-1       Running                                                                                                                                                                                                                             0.0s
 ✔ Container motion-singularity_api-1               Running                                                                                                                                                                                                                             0.0s
 ✔ Container motion-singularity_content_provider-1  Running                                                                                                                                                                                                                             0.0s
 ✔ Container motion-singularity_dataset_worker-1    Running                                                                                                                                                                                                                             0.0s
Attaching to motion-db-1, motion-motion-1, motion-singularity_admin_init-1, motion-singularity_api-1, motion-singularity_content_provider-1, motion-singularity_dataset_worker-1, motion-singularity_deal_pusher-1, motion-singularity_deal_tracker-1
motion-singularity_admin_init-1        | 2023-10-11T20:09:07.022Z       INFO    database        database/connstring_cgo.go:35   Opening postgres database
motion-singularity_admin_init-1        | 2023-10-11T20:09:07.034Z       INFO    model   model/migrate.go:51     Auto migrating tables
motion-singularity_admin_init-1 exited with code 0
dependency failed to start: container motion-singularity_api-1 has no healthcheck configured

@Angelo-gh3990
Copy link
Contributor

.env set

SINGULARITY_REF=:v0.5.0
MOTION_STORAGE_PROVIDERS=f0*****
MOTION_WALLET_KEY=36563703235366b3122******
SINGULARITY_CONTENT_PROVIDER_DOMAIN=http://x.x.x.x:7778

@masih
Copy link
Member Author

masih commented Oct 11, 2023

Thanks @Angelo-gh3990 , could you also post the which commit or version of the motion repo you are trying this on please? (output of git rev-parse HEAD would be great)

@Angelo-gh3990
Copy link
Contributor

Angelo-gh3990 commented Oct 11, 2023 •
edited
Loading

motion# git rev-parse HEAD
f0e5388 "f0e5388af2d471a49bb6b4e9efd666dd75720dc9"

@masih masih added the P1 label Oct 11, 2023
@Angelo-gh3990 Angelo-gh3990 mentioned this issue Oct 11, 2023
Closed
@Angelo-gh3990
Copy link
Contributor

Angelo-gh3990 commented Oct 11, 2023 •
edited
Loading

This solves it I think, but don't know if that's ok that way: #156 @masih

@Angelo-gh3990
Copy link
Contributor

Angelo-gh3990 commented Oct 11, 2023 •
edited
Loading

Not sure if the Motion REST api builds that way, but will check in a second. But at least now we know where to look for!

@schreck23
Copy link

After updating with 155 on a VM I see the following:

I just applied the 155 mod and trying on the secondary VM I have and I get this now:
ubuntu@staff-schreck01:~/motion$ sudo docker-compose up
Building motion
[+] Building 1.0s (2/2) FINISHED docker:default
=> [internal] load build definition from Dockerfile 0.2s
=> => transferring dockerfile: 2B 0.0s
=> [internal] load .dockerignore 0.4s
=> => transferring context: 2B 0.0s
ERROR: failed to solve: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount2937127166/Dockerfile: no such file or directory
ERROR: Service 'motion' failed to build : Build failed

@Angelo-gh3990
Copy link
Contributor

For reference , running it on a 16 core / 128Gb VM

@xinaxu xinaxu self-assigned this Oct 17, 2023
This was referenced Oct 17, 2023
Merged
Merged
xinaxu added a commit to data-preservation-programs/singularity that referenced this issue Oct 17, 2023
@xinaxu
Add curl to container image for health check (#389)
e8c111f 
This is the first step to resolve
- filecoin-project/motion#155

This allows docker compose to define a health check based on curl
xinaxu added a commit that referenced this issue Oct 17, 2023
@xinaxu
Add health check to Singularity API (#164)
7230d07 
This resolves #155 
* This will consume the new Singularity version v0.5.2 which needs to
wait for below
- [x] data-preservation-programs/singularity#389
  - [x] Release v0.5.2 in Singularity
* Modified docker-compose-local-dev.yml
  - Removed abundant overrides
* Added docker-compose-local-dev-with-singularity.yml
  - This will work with a locally cloned Singularity repo
* Updated compose file in integration test
* Updated Github action to use the correct path of
filecoin-proof-parameters
@celine3650 celine3650 mentioned this issue Oct 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xinaxu xinaxu

Labels
bug Something isn't working P1
Projects
Motion Team
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add health check to Singularity API filecoin-project/motion
4 participants
@masih @xinaxu @Angelo-gh3990 @schreck23