Style attribute manipulation fixes #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed overwrites of previously-set style properties on DOM objects, like the
<body>. This was causing problems if you, for example, had a background-image css property set on the body, and opened a jsOnlyLightBox. Since the lightbox overwrote the entire style property, all other previously set properties were lost. This is now fixed by setting style properties using the style array method:obj.style['background-image'] = 'url(logo.png)';This pull request contains the changed
lightbox.jsfile, and the compressed and mangledlightbox.min.jstoo. I useduglify-js -m -cto generate this minified file.