Normalize the path using replace(). #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows `os.path.normpath()` will add backslashes and quotes to the path which git can't handle.
CrossVR
referenced
this pull request
Jul 30, 2016
Apparently Mercurial can have paths such as 'foo//bar', so normalize all paths. Signed-off-by: Felipe Contreras <[email protected]>
git-remote-hg
Outdated
| @@ -265,7 +265,7 @@ class Parser: | |||
| return (user, int(date), -tz) | |||
|
|
|||
| def fix_file_path(path): | |||
| path = os.path.normpath(path) | |||
| path.replace('//', '/') | |||
There was a problem hiding this comment.
You have to set path = path.replace('//', '/'). Otherwise the replaced string isn't saved.
There was a problem hiding this comment.
That's odd, because it worked for me. I'll correct it.
|
This solved the issue of paths being falsly detected as new for me. |
|
Hi, everybody! Something like that... |
felipec
force-pushed
the
master
branch
2 times, most recently
from
62ccc3c
to
6e13c1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows
os.path.normpath()will add backslashes and quotes to the path which git can't handle.The original commit 978314a mentions that the intention for
os.path.normpath()was to normalize paths with 'foo//bar'. Thus to make sure we don't get unintended consequences I suggest a manual replacement.