Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not require uri if redisClient object provided. #196

Open
wants to merge 2 commits into
base: release
Choose a base branch
from

Conversation

palmtown
Copy link
Contributor

@palmtown palmtown commented Mar 2, 2024

Summary

  • Tell us about the problem your pull request is solving.

If passing a redisClient object as shown in Exhibit 1, current code will throw an error as it is expecting the uri. However, when passing the redisClient the uri is not required.

Exhibit 1
app.configure( sync({ redisClient }) );

  • Are there any open issues that are related to this?

#197

  • Is this PR dependent on PRs in other repos?

No

If so, please mention them to keep the conversations linked together.

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant