refactor: consistent remove, perf selector, deps, tests

[fratzinger]

• .remove() behaves the same way as other methods, do a ._get() with raw: false
• selector only when necessary
• update dependencies
• update tests with NotFound integer id

[DaddyWarbucks]

I made a couple of comments. But they started getting redundant. I like the new this.select method. The main point I wanted to make is that if we update the select method, It becomes much cleaner to use.

select(data, params) {
  return select(params, this.id)(data) 
}

// If you want to get uber performant, then we can do the  $select
// check ourselves, which would save result.length number of
// useless functions being made and then GC'ed
select(data, params) {
  if (!params.query?.$select?.length) {
    return data;
  }
  return select(params, this.id)(data) 
}


// Then used as
return this.select(results, params)

Then we no longer need to "setup" some select function every method. We can just use this.select(data, params) directly. And, that actually makes this.select a valuable method for the developer to use directly themselves if needed.

All the remove stuff looks good to me!

[DaddyWarbucks]

I think we can just import this as select without having to rename it now. Adding selector as a method cleans up the code/renaming stuff.

[DaddyWarbucks]

If we update this.select, then this code simplifies to

if (isPresent(sequelizeOptions.attributes)) {
  return this.select(instance.toJSON(), params);
}

[DaddyWarbucks]

Not to be nit-picky about naming stuff, but I think this can be select instead of selector. Like I said above, if we don't have to rename the select import from commons, there is no longer a need to invent a new word selector.

[DaddyWarbucks]

Even better. Let's change this to

select(data, params) {
  return select(params, this.id)(data)
}

[DaddyWarbucks]

Same here. If we update this.select, then this code simplifies to

const result = this.select(instance.toJSON(), params)