Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skipPasswordHash option #226

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

jd1378
Copy link
Contributor

@jd1378 jd1378 commented Mar 12, 2024

Summary

resolves #225

I'll try to add tests while you review changes

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for feathers-a-m ready!

Name Link
🔨 Latest commit 1048652
🔍 Latest deploy log https://app.netlify.com/sites/feathers-a-m/deploys/65f06dd05b8f640008e84945
😎 Deploy Preview https://deploy-preview-226--feathers-a-m.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fratzinger
Copy link
Collaborator

Nice! lgtm.

@jd1378
Copy link
Contributor Author

jd1378 commented Mar 12, 2024

@fratzinger I'm finished adding tests, please take a look again :)

thank you

@jd1378
Copy link
Contributor Author

jd1378 commented Mar 30, 2024

Hi @fratzinger
any eta on this ? I need this :(

@eXigentCoder
Copy link

Hey all, this is exactly what I need any chance of getting it merged in? Anything I can do to help?

@claustres claustres merged commit f1e81d2 into feathersjs-ecosystem:master Jul 8, 2024
10 of 12 checks passed
@claustres
Copy link
Collaborator

Hi, generated a new minor release v5.1.0, let me know if it's working. Unfortunately I failed to generate the changelog, there is probably a breaking change with the latest API, will try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to let resolvers hash the password
4 participants