Skip to content

Commit

Permalink
fix: aiokafka 0.11.0 error when creating topics (#631)
Browse files Browse the repository at this point in the history
  • Loading branch information
somnam committed Jul 10, 2024
1 parent a489db3 commit 02ff777
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 215 deletions.
1 change: 0 additions & 1 deletion .coveragerc
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ omit =

# not needed
*/faust/utils/functional.py
*/faust/utils/kafka/*
*/faust/utils/iso8601.py
*/faust/utils/platforms.py
*/faust/utils/tracing.py
Expand Down
1 change: 0 additions & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
'faust.types._env',
'faust.utils',
'faust.utils._iso8601_python',
r'faust.utils.kafka.*',
'faust.web',
r'faust.web.apps.*',
'faust.web.apps.stats.app',
Expand Down
48 changes: 0 additions & 48 deletions extra/bandit/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -1490,54 +1490,6 @@
"loc": 153,
"nosec": 0
},
"faust/utils/kafka/__init__.py": {
"CONFIDENCE.HIGH": 0.0,
"CONFIDENCE.LOW": 0.0,
"CONFIDENCE.MEDIUM": 0.0,
"CONFIDENCE.UNDEFINED": 0.0,
"SEVERITY.HIGH": 0.0,
"SEVERITY.LOW": 0.0,
"SEVERITY.MEDIUM": 0.0,
"SEVERITY.UNDEFINED": 0.0,
"loc": 1,
"nosec": 0
},
"faust/utils/kafka/protocol/__init__.py": {
"CONFIDENCE.HIGH": 0.0,
"CONFIDENCE.LOW": 0.0,
"CONFIDENCE.MEDIUM": 0.0,
"CONFIDENCE.UNDEFINED": 0.0,
"SEVERITY.HIGH": 0.0,
"SEVERITY.LOW": 0.0,
"SEVERITY.MEDIUM": 0.0,
"SEVERITY.UNDEFINED": 0.0,
"loc": 1,
"nosec": 0
},
"faust/utils/kafka/protocol/admin.py": {
"CONFIDENCE.HIGH": 0.0,
"CONFIDENCE.LOW": 0.0,
"CONFIDENCE.MEDIUM": 0.0,
"CONFIDENCE.UNDEFINED": 0.0,
"SEVERITY.HIGH": 0.0,
"SEVERITY.LOW": 0.0,
"SEVERITY.MEDIUM": 0.0,
"SEVERITY.UNDEFINED": 0.0,
"loc": 61,
"nosec": 0
},
"faust/utils/kafka/protocol/api.py": {
"CONFIDENCE.HIGH": 0.0,
"CONFIDENCE.LOW": 0.0,
"CONFIDENCE.MEDIUM": 0.0,
"CONFIDENCE.UNDEFINED": 0.0,
"SEVERITY.HIGH": 0.0,
"SEVERITY.LOW": 0.0,
"SEVERITY.MEDIUM": 0.0,
"SEVERITY.UNDEFINED": 0.0,
"loc": 47,
"nosec": 0
},
"faust/utils/platforms.py": {
"CONFIDENCE.HIGH": 3.0,
"CONFIDENCE.LOW": 0.0,
Expand Down
2 changes: 1 addition & 1 deletion faust/transport/drivers/aiokafka.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
for_code,
)
from aiokafka.partitioner import DefaultPartitioner, murmur2
from aiokafka.protocol.admin import CreateTopicsRequest
from aiokafka.protocol.metadata import MetadataRequest_v1
from aiokafka.structs import OffsetAndMetadata, TopicPartition as _TopicPartition
from aiokafka.util import parse_kafka_version
Expand Down Expand Up @@ -82,7 +83,6 @@
)
from faust.types.auth import CredentialsT
from faust.types.transports import ConsumerT, PartitionerT, ProducerT
from faust.utils.kafka.protocol.admin import CreateTopicsRequest
from faust.utils.tracing import noop_span, set_current_span, traced_from_parent_span

__all__ = ["Consumer", "Producer", "Transport"]
Expand Down
1 change: 0 additions & 1 deletion faust/utils/kafka/__init__.py

This file was deleted.

1 change: 0 additions & 1 deletion faust/utils/kafka/protocol/__init__.py

This file was deleted.

106 changes: 0 additions & 106 deletions faust/utils/kafka/protocol/admin.py

This file was deleted.

55 changes: 0 additions & 55 deletions faust/utils/kafka/protocol/api.py

This file was deleted.

2 changes: 1 addition & 1 deletion tests/unit/tables/test_wrappers.py
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def wset(self, *, iwtable, event):

@pytest.fixture()
def data(self, *, freeze_time, iwtable):
iwtable.key_index_table = {k: 1 for k in self.TABLE_DATA}
iwtable.key_index_table = dict.fromkeys(self.TABLE_DATA, 1)
iwtable.table._data = {}
for w in iwtable.table._window_ranges(freeze_time.time):
iwtable.table._data.update({(k, w): v for k, v in self.TABLE_DATA.items()})
Expand Down

0 comments on commit 02ff777

Please sign in to comment.