pass settings as hash to Client and allow it to resolve security #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red credentials, assume_rle, etc)
svanzoest
approved these changes
Sep 4, 2018
|
@timothy-volvo Conflicts |
|
@JesseScott conflicts were addressed. 👍 |
|
@joshdholtz it would be great to have this merged. |
|
This LGTM! Can this be merged? |
|
@joshdholtz Could you merge this PR? |
ghost
mentioned this pull request
joshdholtz
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue 54
Pass the configuration as a hash to the client rather then instantiating the Credentials and setting the global config.
This allows the client to resolve settings such as role_arn from the config and credentials file