node.hpp: Fix process_bulk case in constexpr #93

frankosterfeld · 2023-06-21T08:58:49Z

Need else in if constexpr, otherwise the code below still requires the implementation to have process_one, even if never called. (GCC 12.3.0)

frankosterfeld · 2023-06-21T09:00:57Z

include/node.hpp

-                    meta::tuple_for_each([i](auto &output_range, auto &result) { result.copy_to(output_range.data() + i, stdx::element_aligned); }, writers_tuple, results);
-                    i += w;
-                }
-            });
        } else {


Make sure to look at this with "Hide whitespace"...

Need else in if constexpr, otherwise the code below still requires the implementation to have process_one, even if never called. (GCC 12.3.0)

frankosterfeld · 2023-06-22T12:09:36Z

Fixed upstream

frankosterfeld requested a review from RalphSteinhagen June 21, 2023 08:58

frankosterfeld temporarily deployed to configure coverage June 21, 2023 08:58 — with GitHub Actions Inactive

frankosterfeld had a problem deploying to configure coverage June 21, 2023 08:58 — with GitHub Actions Failure

frankosterfeld temporarily deployed to configure coverage June 21, 2023 08:58 — with GitHub Actions Inactive

frankosterfeld requested a review from ivan-cukic June 21, 2023 08:59

frankosterfeld commented Jun 21, 2023

View reviewed changes

Fix process_bulk case in constexpr

90a9bb4

Need else in if constexpr, otherwise the code below still requires the implementation to have process_one, even if never called. (GCC 12.3.0)

frankosterfeld force-pushed the frank/compile-fixes branch from d27c649 to 90a9bb4 Compare June 21, 2023 09:11

frankosterfeld temporarily deployed to configure coverage June 21, 2023 09:11 — with GitHub Actions Inactive

frankosterfeld closed this Jun 22, 2023

RalphSteinhagen deleted the frank/compile-fixes branch August 5, 2023 08:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

node.hpp: Fix process_bulk case in constexpr #93

node.hpp: Fix process_bulk case in constexpr #93

frankosterfeld commented Jun 21, 2023

frankosterfeld Jun 21, 2023

frankosterfeld commented Jun 22, 2023

node.hpp: Fix process_bulk case in constexpr #93

node.hpp: Fix process_bulk case in constexpr #93

Conversation

frankosterfeld commented Jun 21, 2023

frankosterfeld Jun 21, 2023

Choose a reason for hiding this comment

frankosterfeld commented Jun 22, 2023