Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: add thread pool backed parallel implementation to "simple" and "breadth_first" schedulers #78

Merged
merged 6 commits into from
Jun 27, 2023
Merged

scheduler: add thread pool backed parallel implementation to "simple" and "breadth_first" schedulers #78

merged 6 commits into from
Jun 27, 2023

Conversation

wirew0rm
Copy link
Member

@wirew0rm wirew0rm commented Jun 2, 2023

Adds basic multi-threaded implementations for the simple scheduling algorithms (simple & breadth-first).

fixes #76

@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 10:00 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 15:17 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 15:17 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 15:17 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 15:17 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 15:17 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 2, 2023 15:17 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 13:23 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 13:23 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 13:23 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 13:23 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 13:23 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 13:23 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 13:23 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 13:23 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 27, 2023 15:58 — with GitHub Actions Inactive
RalphSteinhagen
RalphSteinhagen approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the in-person review... was IMO more efficient since this wasn't just checking for errors but also designing and evolving the overall scheduler design.

This looks good from my point of view and is an excellent basis for further extensions! 👍

@RalphSteinhagen RalphSteinhagen merged commit e9e5ace into main Jun 27, 2023
16 checks passed
@RalphSteinhagen RalphSteinhagen deleted the schedulerMultiThreaded branch June 27, 2023 16:19
@RalphSteinhagen RalphSteinhagen linked an issue Jul 15, 2023 that may be closed by this pull request
[0pt] Add cancellation support to ThreadPool fair-acc/opencmw-cpp#244
Closed
@RalphSteinhagen RalphSteinhagen mentioned this pull request Jul 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

graph: multithreaded schedulers [0pt] Add cancellation support to ThreadPool
2 participants
@wirew0rm @RalphSteinhagen