CircularBuffer: do not reset empty PublishableOutputRange #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an empty PublishableOutputRange is requested, do not reset the index, offet and internal span of the buffer. This solution was suggested by @drslebedev to fix bugs in which the buffer state would become corrupted and report negative values (casted to uint64_t) for the available number of elements, etc. Signed-off-by: Daniel Estévez <[email protected]>
drslebedev
approved these changes
Sep 9, 2024
This was referenced Sep 10, 2024
|
@all-contributors please add @daniestevez for code |
|
I've put up a pull request to add @daniestevez! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an empty PublishableOutputRange is requested, do not reset the index, offet and internal span of the buffer.
This solution was suggested by @drslebedev to fix bugs in which the buffer state would become corrupted and report negative values (casted to uint64_t) for the available number of elements, etc.
I have tested this change on the gr4-packet-modem codebase and everything seems to work correctly with the single-threaded scheduler. Things that mysteriously failed before now work. All the QA tests in gr4-packet-modem and gnuradio4 pass. There are still some things in gr4-packet-modem that don't work with the multi-threaded scheduler, but probably the problem is unrelated.