Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soapy: added set vs. actual center frequency check #371

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

RalphSteinhagen
Copy link
Member

No description provided.

Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

one small leftover duplication that I think was missed during cleanup.

Just to see if I understood it right and document a bit the underlying issue: If the user requests a setting value that is not supported by the actual hardware, it might be changed to an arbitrary value that the driver considers closest to the requested value. This is a problem since the further processing may depend on settings like samplerate and gain having the configured value.
With this change, requesting a value that the hardware cannot accommodate is an exception (stopping flowgraph execution?).
I guess this fail-early paradigm is less error-prone than trying to reconcile the requested and actual settings.

Q: recovering is possible by setting a supported setting and restarting the graph processing?

blocks/soapy/include/gnuradio-4.0/soapy/Soapy.hpp Outdated Show resolved Hide resolved
Signed-off-by: rstein <[email protected]>
Copy link

sonarcloud bot commented Jun 27, 2024

@RalphSteinhagen RalphSteinhagen merged commit 912b5f7 into main Jun 27, 2024
9 of 10 checks passed
@RalphSteinhagen RalphSteinhagen deleted the soapyFix branch June 27, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants