Message-based API for block and edge creation and deletion #357
Conversation
ivan-cukic
force-pushed
the
ivan/message-updates
branch
from
2baa60c
to
64c6630
Compare
There was a problem hiding this comment.
@ivan-cukic this looks very good. I especially like the new qa_GraphMessage unit tests. Very concise and easy to follow! Well done! 👍
I guess some parts are still a bit final-clean-up-WIP but the things I found are only minor (i.e. leftover debugging prints etc.) that should not prevent the merge as soon as the CI passes.
Feel free to squash-merge once you have done the final clean-up/checks!
Again, Good work!
N.B. also the new clang-format pays off ... more functionality for less code to read!
| static_assert(kIsOutput && std::remove_cvref_t<Other>::kIsInput); | ||
| static_assert(std::is_same_v<value_type, typename std::remove_cvref_t<Other>::value_type>); |
ivan-cukic
force-pushed
the
ivan/message-updates
branch
2 times, most recently
from
66c4c90
to
dd8ae77
Compare
ivan-cukic
changed the title
ivan-cukic
force-pushed
the
ivan/message-updates
branch
2 times, most recently
from
c9a0d5a
to
16f8428
Compare
ivan-cukic
force-pushed
the
ivan/message-updates
branch
from
16f8428
to
b573875
Compare
There was a problem hiding this comment.
@ivan-cukic thanks for the changes. Will merge this once the CI passes!
This is a good milestone.
As on open-ended question: since we can now change both block settings and the graph topology changes ... maybe we could drop the direct block slide access to settings which in turn would allow to remove the mutexes that are presently protecting the setting interface from direct access.
- Runtime Graph::emplaceBlock that accepts stringified block info - Added messages for emplacing, removing and replacing blocks (as well as their reply messages) - Added messages for connecting and disconnecting ports - Introduced ENABLE_BLOCK_REGISTRY and ENABLE_BLOCK_PLUGINS cmake options - Introduced GNURADIO4_PLUGIN_DIRECTORIES environment variable to override the paths where the global plugin loader searches for plugins Signed-off-by: Ivan Čukić <[email protected]>
ivan-cukic
force-pushed
the
ivan/message-updates
branch
from
b573875
to
95514bd
Compare
Signed-off-by: Ivan Čukić <[email protected]>
|
No description provided.