Fix clang-18 compilation error #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:ranges::contains. Signed-off-by: drslebedev <[email protected]>
RalphSteinhagen
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Thanks for the fixing/downgrading the expression.
The std::ranges::contains seems to be a C++23 feature, and with the exception of std::expected and eventually std::println(...) we should minimise the use of C++23 features for now.
Can be merged as is.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix clang-18 compilation error: use std::ranges::find instead of std::ranges::contains.