Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: rework Tag handling #340

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Core: rework Tag handling #340

merged 2 commits into from
Jun 14, 2024

Commits on Jun 14, 2024

  1. Core: rework Tag handling 

    The automatic tag forwarding implemented in Block::workInternal was was not working for
ASYNC ports since in this case the Block cannot determine a priori if samples will
be consumed and consequently cannot perform an early return ahead of the unconditional
tag forwarding and consumption.

This change introduces an extension of the ConsumableInputRange, which additionally takes
care of consuming all tags up to the first sample of the currently processed chunk.

Also all tag merging logic is moved from Port to Block, while the logic for preparing the
consumableInput or producableOutput ranges is moved into the Port.

Only forward initial tags before starting the flowgraph instead of
during initialisation, when the buffers are not connected yet.

In CircularBuffer, make PublishableOutputRange pubblish in destructor

This makes the PublishableOutputRange behave like the corresponding
InputRange by only marking samples for being published and only
publishing in the destructor.

Evaluate actually processed samples after process bulk was called.

Add port unittest and fix off by one problem

Change sequence from -1 to 0 to avoid tag offset

Signed-off-by: Alexander Krimm <[email protected]>
    @wirew0rm
    wirew0rm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5c9d8cb View commit details
    Browse the repository at this point in the history

  2. Graph: fix modification tag 

    Signed-off-by: Alexander Krimm <[email protected]>
    @wirew0rm
    wirew0rm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    159bc1f View commit details
    Browse the repository at this point in the history