Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.18 module support #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbuchbinder
Copy link

Add proper module support for go 1.18, otherwise things that require submodules (like generators, etc) will not be able to resolve properly in the build system.

Copy link
Collaborator

@cebarks cebarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this only needed if we beep used the multi-module workspace? I've only just started reading into the changes they introduced in 1.18 RE: multi-module workspaces but it seems like since we only have 1 main module file, nothing will change for beep.

@@ -0,0 +1,2 @@
*~
go.sum
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MarkKremer pushed a commit to MarkKremer/beep that referenced this pull request Apr 6, 2024
add retro as project using beep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants