-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files starting with dot #8045
base: main
Are you sure you want to change the base?
Files starting with dot #8045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work with .ext
as import? Like if you specify custom extension and just import nameless file?
import something from './.ext'
https://flow.org/en/docs/config/options/#toc-module-file-ext-string
Or just nameless files in general like .js
?
I'm not sure I'm comfortable with deleting this behavior. Like there's a lot of JS for me in I suppose I'm fine making it an option? Like if someone wants to set |
@gabelevi I think this the better way, I go make this changes |
@gabrielrumiranda can you add tests with nameless files? |
@goodmind I separate the test in another folders, when you tell nameless file you tell a file with name |
@gabrielrumiranda yeah, like |
I try but don't work |
Other thing, files begin with dot inside a node_module cannot be import using relative path. I tested this in a simple node.js project and don't work too |
Hmm |
@gabrielrumiranda it should work now |
This PR solve the problem of this issue. Lets you import files that start with dots