Use admonitions in several pages #1595
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The action (check-translation) is failing due to your repository permission not allowing writing, as discussed in other PRs |
|
Add manually to test if the action works '{"labels":["requires-translation-es","requires-translation-fr","requires-translation-it","requires-translation-ja","requires-translation-ko","requires-translation-pt-br","requires-translation-ru","requires-translation-sk","requires-translation-zh-cn","requires-translation-zh-tw"]}', |
The permissions of my repository don't affect anything in the PRs; the rules in this repository do. That's why in this PR (#1588) it works fine, because @crandmck was the one who opened it. |
| @@ -3,7 +3,7 @@ | |||
| This is a built-in middleware function in Express. | |||
| It serves static files and is based on [serve-static](/resources/middleware/serve-static.html). | |||
|
|
|||
| <div class="doc-box doc-info" markdown="1">NOTE: For best results, [use a reverse proxy](/{{page.lang}}/advanced/best-practice-performance.html#use-a-reverse-proxy) cache to improve performance of serving static assets. | |||
| <div class="doc-box doc-info" markdown="1">For best results, [use a reverse proxy](/{{page.lang}}/advanced/best-practice-performance.html#use-a-reverse-proxy) cache to improve performance of serving static assets. | |||
There was a problem hiding this comment.
Why aren't we using the admonition template here?
There was a problem hiding this comment.
Because at the time of Jekyll transforming the link it was giving me problems, I have the solution but I don't entirely like it.
| @@ -48,7 +48,7 @@ app.use(express.static('files')) | |||
|
|
|||
| Express looks up the files in the order in which you set the static directories with the `express.static` middleware function. | |||
|
|
|||
| <div class="doc-box doc-info" markdown="1">NOTE: For best results, [use a reverse proxy](/{{page.lang}}/advanced/best-practice-performance.html#use-a-reverse-proxy) cache to improve performance of serving static assets. | |||
| <div class="doc-box doc-info" markdown="1">For best results, [use a reverse proxy](/{{page.lang}}/advanced/best-practice-performance.html#use-a-reverse-proxy) cache to improve performance of serving static assets. | |||
There was a problem hiding this comment.
Why aren't we using the admonition template here?
There were several places where the use of admonitions is still not applied; this greatly improves the guidance in the documentation.