Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat - create page by action to verify status - (TEST) #1586

Open
wants to merge 31 commits into
base: gh-pages
Choose a base branch
from

Conversation

carlosstenzel
Copy link
Contributor

@carlosstenzel carlosstenzel commented Aug 30, 2024

Captura de Tela 2024-08-30 às 20 23 52

Ref #1480

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 7dd9444
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/66d5114222d09f000858e137
😎 Deploy Preview https://deploy-preview-1586--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


const ignoreFiles = ['resources/status-translate']

const languageBaseFiles = ['guide', 'resources', 'resources/middleware', 'starter', 'advanced', '3x', '4x', '5x']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary to keep checking if the API versions are translated, and I don't think it will be necessary to keep looking at 'resources/middleware' either, as it is an external resource that is extracted by running a script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the language (th) there are translated 'resources/middleware'

https://deploy-preview-1586--expressjscom-preview.netlify.app/en/resources/status-translate

Captura de Tela 2024-09-01 às 22 09 38

the API page has been translated into other languages

@bjohansebas
Copy link
Member

It would be better if this workflow were a task that repeats periodically and checks the labels of the PRs as proposed in #1480.

@carlosstenzel
Copy link
Contributor Author

It would be better if this workflow were a task that repeats periodically and checks the labels of the PRs as proposed in

we can create the schedule in main (gh-pages), but I don't know if the repository is configured to allow direct commits, so I want to do the same thing on every pull request

ref - https://docs.github.com/pt/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule

@crandmck
Copy link
Member

crandmck commented Sep 2, 2024

This is potentially useful, but the whole area of localization (translation) probably needs to be reviewed and discussed more holistically...

Anyway, I have a few questions & comments on this PR specifically:

  • How does this information get generated?
  • Simply determining if a page has been translated is not that helpful (it's pretty obvious if the page doesn't exist in the locale dir or if it's still in en). What would be more useful would be determining if the en version matches the localized version, which is likely quite difficult without translation AI. Even date-checking the localized version vs. en version migt not be sufficient.
  • This probably doesn't need to have its own page (it's only of interest to a small subset of contributor), but rather should be linked from a Documentation section in the Contributing page.

TBH, I'd like to discuss localization with the @expressjs/express-tc in general, and since we may have access to IBM translation AI, consider re-translating the whole site once we get the docs ready for 5.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants