Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pull request template + compliance check action #5915

Closed
wants to merge 2 commits into from

Conversation

mmkal
Copy link

@mmkal mmkal commented Sep 6, 2024

Based on an X conversation - it seems there's at least one coding course that instructs students to spam express. Hopefully this can help cut it down.

https://x.com/mmkalmmkal/status/1828811200802816185

I'm not 100% sure the compliance check will actually work with the default GitHub token. If not there may be a free GitHub app that can do something similar.

Based on an X conversation. Hopefully this can cut down spam. Will add a GitHub Actions workflow to auto-close pull requests that ignore the template.

https://x.com/mmkalmmkal/status/1828811200802816185
@IamLizu
Copy link
Member

IamLizu commented Sep 6, 2024

I'm not 100% sure the compliance check will actually work with the default GitHub token. If not there may be a free GitHub app that can do something similar.

I also think it won't work. Because GITHUB_TOKEN generated by a PR author who has no write access to this repository won't get write scope, so they won't be able to update or create comment in the PR.

We have a similar situation in expressjs/expressjs.com#1553

@mmkal
Copy link
Author

mmkal commented Sep 6, 2024

I also think it won't work. Because GITHUB_TOKEN generated by a PR author who has no write access to this repository won't get write scope, so they won't be able to update or create comment in the PR.

I am not confident of it, but GitHub might allow GITHUB_TOKEN to modify the PR that triggered it in the first place. The problem in that referenced issue might come from the workflow_dispatch trigger, maybe?

I'll try it out on a test repo and report back here.

@jonchurch
Copy link
Member

A few of us have suggested things in this same vein, but we've opted to not go this route.

I'd rather not optimize for the misguided folks and add these gates. It is a good thought, and ty for thinking of us. We close and lock at least a few of these a week, which is the easiest part of the work here 😉

@jonchurch jonchurch closed this Sep 7, 2024
@mmkal
Copy link
Author

mmkal commented Sep 7, 2024

Fair enough!

@wesleytodd
Copy link
Member

Yeah, this has been ongoing at a low simmer for a long time now. The one thing I really like from this PR is the disclaimer, which I think if we just did that maybe I would be onboard with.

# STOP! Read this before submitting your pull request
## ⚠️ Warning ⚠️
This repository is not for educational exercises or trivial changes. Pull requests that do not provide substantial value will be closed immediately.
-->```

Maybe we could just land this alone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants