[Luhn algorithm] Replace _ with arrows #2466
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
| @@ -22,7 +22,8 @@ The first step of the Luhn algorithm is to double every second digit, starting f | |||
| We will be doubling | |||
|
|
|||
| ```text | |||
| 4_3_ 3_9_ 0_4_ 6_6_ | |||
| 4539 3195 0343 6467 | |||
There was a problem hiding this comment.
Could you please implement @kotp 's suggest of using an odd number of digits?
There was a problem hiding this comment.
I think @kotp's suggestion makes it less clear. The bit everyone misses is "starting from the right" not "every second digit". If we make it odd number of digits, then we double the second one from the left and from the right, which I think makes it confusing again.
There was a problem hiding this comment.
It was exactly what I was indicating with the "starting from the right" as that is what I see people miss as well.
So having a second example that shows this, with an odd number of digits, makes it apparent that it is not "start from the right".
It shows them side by side (or vertically) together, and visually shows the difference.
I agree, if we make it odd number of digits, and that alone, it would definitely be confusing, but along with the example of the even number of digits, this helps (to me) clarify visually, that there is something different going on on the left hand side.
There was a problem hiding this comment.
Well, it is already in. So it does not matter, if this matters it will eventually come in. So do not sweat it. I did not recognize that it was already merged and so the point is moot.
|
Forum discussion here |
[Luhn algorithm] Replace _ with arrows