Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix: Ensure whole matrix is correct #2199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

homersimpsons
Copy link

There are some proposed solutions where the mentee submit solution that would emit extra empty rows. For instance with an off by one error in a for-loop.

By checking that the whole matrix is exactly as expected we can catch such mistakes.

(Re-open of #2195, cc @SleeplessByte)

There are some proposed solutions where the mentee submit solution that would emit extra empty rows. For instance with an off by one error in a for-loop.

By checking that the whole matrix is exactly as expected we can catch such mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 7, 2023
@SleeplessByte SleeplessByte reopened this Feb 7, 2023
@SleeplessByte
Copy link
Member

@exercism/reviewers please :)

@kotp
Copy link
Member

kotp commented Feb 12, 2023

Link back to Forum discussions for continuity:

https://forum.exercism.org/t/pull-requrest-on-exercism-javascript/3440/8

@glennj
Copy link
Contributor

glennj commented Feb 13, 2023

The new tests take different inputs, so it seems like they should have different property names.

@homersimpsons
Copy link
Author

The new tests take different inputs, so it seems like they should have different property names.

Good catch, should I just remove the "property" field completely ? Or should I use a value like "matrix" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants