Improve error printing in process_posix.rs #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The posix_spawn_* family of functions returns != 0 on error, and the return is an error code that can be passed to strerror(). So check for `!= 0`, not `< 0`. (Error codes that can be passed to strerror() are in practice > 0!) Rename `check_posix` to `check_posix_spawn` too, to make it clear it's only for checking return codes from functions in the posix_spawn_* family. * The normal C runtime functions return a code < 0 on error, and put the error code in errno. Add a check_ret_errno function and call that instead of check_posix for non-spawn functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The posix_spawn_* family of functions returns != 0 on error, and the return is an error code that can be passed to strerror(). So check for
!= 0, not< 0. (Error codes that can be passed to strerror() are in practice > 0!) Renamecheck_posixtocheck_posix_spawntoo, to make it clear it's only for checking return codes from functions in the posix_spawn_* family.The normal C runtime functions return a code < 0 on error, and put the error code in errno. Add a check_ret_errno function and call that instead of check_posix for non-spawn functions.