Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] New config setting ´system.languageFileCsvSeparator´ #430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

awestbunk
Copy link

@awestbunk awestbunk commented Jan 6, 2024

The option allows to define the separator character used in the translation files and updates all german files to use ´;´ instead of ´,´. Default to ´,´ for backwards compatibility.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Several languages e.g. german use , as regular set character. Since the translation files use , as column separator the german language breaks the translation behaviour in some cases.

Issue Number: N/A

What is the new behavior?

The new setting allows to define any other character to be used as separator in language files, e.g. ; which lead to working translations when the label contains a ,.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This commit also updates the separator character to ;. If you use german language update your config/default.json

{
    "shop" : {
        ...
        "language": "de"
    },
    "system": {
        ...
        "languageFileCsvSeparator": ";"
    }
}

…hich allows to define the separator character used in the translation files and updates all german files to use ´;´ instead of ´,´.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant