Ocpp: fix duplicate init (#16277)

evcc-io · Sep 23, 2024 · 0b0d8fd · 0b0d8fd
1 parent 2d9a85b
commit 0b0d8fd
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/charger/ocpp/cs.go b/charger/ocpp/cs.go
@@ -81,12 +81,13 @@ func (cs *CS) RegisterChargepoint(id string, newfun func() *CP, init func(*CP) e
 	cpmu.Lock()
 	defer cpmu.Unlock()
 
-	cp, err := cs.ChargepointByID(id)
-	if err != nil {
-		cp = newfun()
+	// already registered?
+	if cp, err := cs.ChargepointByID(id); err == nil {
+		return cp, nil
 	}
 
-	// should not error
+	// first time- registration should not error
+	cp := newfun()
 	if err := cs.register(id, cp); err != nil {
 		return nil, err
 	}