Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable -Wall -Wextra -Wpedantic -Werror #20

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Enable -Wall -Wextra -Wpedantic -Werror #20

merged 3 commits into from
Jan 3, 2024

Conversation

4c3y
Copy link
Member

@4c3y 4c3y commented Dec 20, 2023 •
edited
Loading

Enable -Wall -Wextra -Wpedantic -Werror for C++17

@4c3y 4c3y added the enhancement New feature or request label Dec 21, 2023
@4c3y 4c3y marked this pull request as ready for review December 22, 2023 11:38
michaelpantic
michaelpantic approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@michaelpantic michaelpantic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! good to be pedantic here :-)

@4c3y 4c3y merged commit 362ada3 into master Jan 3, 2024
9 checks passed
@4c3y 4c3y deleted the feature/w-error branch January 3, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpantic michaelpantic michaelpantic approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4c3y @michaelpantic