SSACFGBuilder: clean up tryRemoveTrivialPhi #15441
Open
+12
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clonker
added
the
has dependencies
clonker
commented
Sep 19, 2024
Comment on lines
-125
to
-130
| // TODO: double check when phiVar occurs in outputs here and what to do about it. | ||
| if (op.outputs.size() == 1 && op.outputs.front() == _phi) | ||
| continue; | ||
| // TODO: check if this always hold - and if so if the assertion is really valuable. | ||
| for (auto& output: op.outputs) | ||
| yulAssert(output != _phi); |
There was a problem hiding this comment.
From a conceptual point of view: A phi function value can never be the output of an operation that isn't the phi function itself, as that would violate the SSA form.
From an implementation point of view: Operation outputs are always emplaced as m_graph.newVariable(m_currentBlock) and beyond that not mutated.
Base automatically changed from
ssaCfg-fix-trivial-phi-fct-removal
to
develop
September 19, 2024 23:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #15429