SSA CFG Liveness #15439
SSA CFG Liveness #15439
Conversation
clonker
added
the
has dependencies
clonker
force-pushed
the
ssaCfg-liveness
branch
from
1f53fe0
to
540668c
Compare
clonker
force-pushed
the
ssaCfg-fix-trivial-phi-fct-removal
branch
from
17b71f7
to
7e9ac48
Compare
clonker
force-pushed
the
ssaCfg-liveness
branch
from
540668c
to
945335d
Compare
| size_t index = 1; | ||
| for (auto const& [function, functionGraph]: functionGraphMapping) | ||
| output << functionGraph->toDot(false, index++); | ||
| output << mainGraph->toDot(false, std::nullopt, _liveness ? _liveness->mainLiveness.get() : nullptr); |
There was a problem hiding this comment.
It is not directly related with this PR, but is here, and also for the functions below, the only cases where we need the boolean _includeDiGraphDefinition to be set to false? Why do we need this parameter at all? I believe we could remove it, or if it's truly necessary to keep, we could remove the digraph definition on line 55 and set the parameter to true.
There was a problem hiding this comment.
It is so that the toDot method of a SSACFG can also be used stand-alone :)
| { | ||
| std::ostringstream output; | ||
| if (_includeDiGraphDefinition) | ||
| output << "digraph SSACFG {\nnodesep=0.7;\ngraph[fontname=\"DejaVu Sans\"]\nnode[shape=box,fontname=\"DejaVu Sans\"];\n\n"; | ||
| if (function) | ||
| output << SSACFGPrinter(*this, _functionIndex ? *_functionIndex : static_cast<size_t>(1), *function); | ||
| output << SSACFGPrinter(*this, _functionIndex ? *_functionIndex : static_cast<size_t>(1), *function, _liveness); |
There was a problem hiding this comment.
I just noticed this now, but why 1 if _functionIndex is null? In fact, why do we even need functionIndex in SSACFGPrinter at all? Doesn't the SSACFG already contain all the functions?
There was a problem hiding this comment.
SSACFG contains only one function (or the main graph), ControlFlow contains all of it :) the indices are needed to disambiguate the nodes in the dot graph
clonker
force-pushed
the
ssaCfg-liveness
branch
from
c9d2f8e
to
58a509f
Compare
clonker
force-pushed
the
ssaCfg-liveness
branch
from
58a509f
to
605aa64
Compare
depends on #15429