Numerical Yul node id handles #15215
Draft
+5,085
−4,799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekpyron
reviewed
Jun 25, 2024
ekpyron
reviewed
Jun 25, 2024
libsolidity/ast/AST.h
Outdated
| yul::Block const& operations() const { return *m_operations; } | ||
| ASTPointer<std::vector<ASTPointer<ASTString>>> const& flags() const { return m_flags; } | ||
|
|
||
| InlineAssemblyAnnotation& annotation() const override; | ||
|
|
||
| private: | ||
| yul::Dialect const& m_dialect; | ||
| std::unique_ptr<yul::YulNameRepository> mutable m_yulNameRepository; |
There was a problem hiding this comment.
Does this really need to be mutable? Usually that's a good indication of some design flaw :-).
There was a problem hiding this comment.
agree, it's one place where I am not happy with the code yet :) it was already on my todo to iron out
clonker
added
the
has dependencies
github-actions
bot
added
the
stale
cameel
removed
stale
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
Due to the size of this PR, I am splitting it up