Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Backport github/workflows: set read-only default permissions to approve workflow #18430

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Aug 11, 2024

Backports commit: 5a02298 from #18368 to release-3.5.

Finishes off one aspect of #18362.

Backports commit: #5a02298ad5a947214ba02655b0a93ac01d4c178a

Signed-off-by: James Blair <[email protected]>
@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ivanvc
Copy link
Member

ivanvc commented Aug 11, 2024

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, James.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 1bdb632 into etcd-io:release-3.5 Aug 11, 2024
27 checks passed
@ivanvc ivanvc mentioned this pull request Aug 22, 2024
2 tasks
@ivanvc
Copy link
Member

ivanvc commented Aug 22, 2024

/retitle [3.5] Backport github/workflows: set read-only default permissions to approve workflow

@k8s-ci-robot k8s-ci-robot changed the title [3.5] Backport github/workflows: set read-only default permissions to approve workflow [3.5] Backport github/workflows: set read-only default permissions to approve workflow Aug 22, 2024
aneesh1 pushed a commit to DataDog/etcd that referenced this pull request Sep 25, 2024
 [3.5] Backport github/workflows: set read-only default permissions to approve workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants