Phi sat 2 #103

CesarCoelho · 2021-08-19T13:24:01Z

The changes needed for the Phi-Sat-2 mission.
This involves mainly (1) the creation of NMF Packages via a maven plugin, (2) support of Apps running in isolation by taking advantage of Linux (one user per App)

dmarszk

Hi @CesarCoelho - in principle looks good. I found a few things to change.
After the fixups, please ensure to stay compliant with https://github.com/esa/nanosat-mo-framework/blob/dev/CONTRIBUTING.md - most notably use the bug-tracker https://gitlab.com/esa/NMF/nmf-issues for new changes.

...nanosat-mo-connector/src/main/java/esa/mo/nmf/nanosatmoconnector/NanoSatMOConnectorImpl.java

dmarszk · 2021-08-30T18:56:09Z

core/nmf-package-lib/src/main/java/esa/mo/nmf/nmfpackage/LinuxUsersGroups.java

+        LinuxUsersGroups.printCommandAndOutput(cmd3, out3);
+    }
+
+    public static void addUserToGroup(String username, String extraGroup) throws IOException {


This does not look like what it is supposed to do. Adding user to a group is typically done via usermod

I think usermod was not available on our OBC. We have busybox and I guess this was a work around. Check here: https://stackoverflow.com/questions/37791873/how-to-add-user-to-a-group-without-usermod

The linked SO post does not resemble what this method implements. I cannot really match it to either GNU adduser:
https://linux.die.net/man/8/adduser
or busybox adduser:
https://www.busybox.net/downloads/BusyBox.html

core/helper-tools/src/main/java/esa/mo/helpertools/helpers/HelperMisc.java

.../nmf-software-management-impl/src/main/java/esa/mo/sm/impl/provider/AppsLauncherManager.java

dmarszk · 2021-08-30T19:09:45Z

.../nmf-software-management-impl/src/main/java/esa/mo/sm/impl/provider/AppsLauncherManager.java

@@ -396,6 +407,9 @@ protected boolean isAppRunning(final Long appId)
      ret.add(str.toString());
    } else {
      if (runAs != null) {
+        if(sudoAvailable){


If sudo is available, sudo su is an antipattern as it escapes the sudoers permission lists - i.e. using sudo + sudoers configuration is the proper way to ensure that supervisor is not running as a privileged user, and thus commands like
su - user123 -c <command> should be replaced with sudo -u user123 <command>. This along with properly tailored system config (i.e. ensuring that user123 belongs to a group which is sudo'able by the supervisor user) will properly utilise linux permissions system.

This is the thorny one... while I agree with you, there was some problem which prevented me from doing what you are suggesting, can't quite recall it however

Please give it a go. Message me if it gives you issues. Perhaps adding -i switch to sudo is enough in case of problems.

dmarszk · 2021-08-30T19:13:18Z

Please also rebase on top of dev branch.

...nanosat-mo-connector/src/main/java/esa/mo/nmf/nanosatmoconnector/NanoSatMOConnectorImpl.java

dmarszk · 2021-12-06T14:47:20Z

core/nmf-package-lib/src/main/java/esa/mo/nmf/nmfpackage/LinuxUsersGroups.java

+                    .append(withGroup ? " --group " : " ")
+                    .append(username);
+        }
+        //String cmd = "useradd $user_nmf_admin -m -s /bin/bash --user-group";


Leftover test code. Remove please.

dmarszk · 2021-12-06T14:51:47Z

See the latest round of comments. In addition:

rebase on top of dev
consider squasing some similar commits (or fixups)
please link as many commits to issues as possible (create new one if needed) - https://gitlab.com/esa/NMF/nmf-issues/-/issues

dmarszk · 2022-09-23T10:45:25Z

...era-acquisitor-system/src/main/java/esa/mo/nmf/apps/CameraAcquisitorSystemCameraHandler.java

@@ -307,7 +307,8 @@ public void takePhotograph(long actionInstanceObjId, int stageOffset, int totalS
        new Duration(casMCAdapter.getExposureTime()),
        casMCAdapter.getGainRed(),
        casMCAdapter.getGainGreen(),
-        casMCAdapter.getGainBlue());
+        casMCAdapter.getGainBlue(),


The API is broken here -> can we patch the StubGenerator to generate multiple constructor wrappers for composites with optional fields?

Yeah, I like the idea. Will come with MOv9

…rties

…radd/userdel to adduser/deluser.

… are stored

…ollows the AppStorage class recommendations.

…ffecting Phi-Sat-2 setup when starting Apps

… now

…e creation of the storage folders

… default when the transport needs to be generated

… argument object.

…tion

…ent folder if it is empty

…ackages

…g the App Ids directly from the Apps Launcher service instead of getting it from the COM Archive

… commands

…ication parameter

dmarszk requested changes Aug 30, 2021

View reviewed changes

dmarszk reviewed Dec 6, 2021

View reviewed changes

...nanosat-mo-connector/src/main/java/esa/mo/nmf/nanosatmoconnector/NanoSatMOConnectorImpl.java Outdated Show resolved Hide resolved

dmarszk reviewed Dec 6, 2021

View reviewed changes

CesarCoelho force-pushed the phi-sat-2 branch from e3abc2e to d7ac791 Compare December 30, 2021 15:01

CesarCoelho force-pushed the phi-sat-2 branch 2 times, most recently from e1dffa8 to 2fbb003 Compare May 27, 2022 11:48

dmarszk reviewed Sep 23, 2022

View reviewed changes

CesarCoelho force-pushed the phi-sat-2 branch from 35c830f to 4a2e434 Compare October 7, 2022 19:19

CesarCoelho force-pushed the phi-sat-2 branch from 552c247 to 476fd81 Compare November 14, 2022 16:18

CesarCoelho force-pushed the phi-sat-2 branch 2 times, most recently from 1f70921 to 871b4f9 Compare February 23, 2023 15:26

CesarCoelho added 17 commits February 23, 2023 16:27

[javadoc] Fixed chmod method javadoc

04f525f

Allows the Apps to be started from a non-root user account

deaab4c

Added a start banner for all NMF Apps with System information

8c6c457

[nmf-app] Changed the location of the comArchive to the home directory

8ea92e9

Moved to the home directory, the comArchive.db and the provider.prope…

18e367f

…rties

Check if sudo is available before using it

cfac887

Code cleanup. Some logs were returning nothing because of: {}

6d07cba

[nmfpack] During installation/uninstallation, replaced the use of use…

bdddc81

…radd/userdel to adduser/deluser.

[pictureprocessor] Code cleanup. Changed directory where the pictures…

5bf556a

… are stored

[nmfpack] Support for additional libs or files.

56b1b8a

The App was using folders outside the restricted area. The code now f…

efb57d1

…ollows the AppStorage class recommendations.

Improved the startup banner

eb098d2

New constructor with ConnectionConsumer. Cleanup of imports

911e3d2

The env variables were not being passed on Linux machines. This was a…

8508b09

…ffecting Phi-Sat-2 setup when starting Apps

Installation is now supported on the Linux on Phi-Sat-2

697cc18

[nmfpack] The NMF Packages can carry fat jars (jar-with-dependencies)…

5833610

… now

The AppStorage class is now setting the correct permissions during th…

c19cece

…e creation of the storage folders

CesarCoelho and others added 20 commits February 23, 2023 16:34

Restored sanity to the file

fe5efda

Code cleanup

2a582fa

Adds a mechanism to configure the transport dispatcher executor threads.

d992ad0

Code refactoring

08ef8fb

Fixes the License Headers

271c002

Prioritize the new jars-nmf folder over the old one & Set autohost as…

533486b

… default when the transport needs to be generated

Adds capability to create NMF Packages with Java inside

ba02a19

Code cleanup

893c190

[nmf-package] Constructor of the NMFPackageBuilder has now a Metadata…

5ec5c40

… argument object.

Disables the support for a dedicated nmf-apps group from the installa…

f6ae25e

…tion

Makes the JRE executable & After deliting a file, delete also the par…

241889b

…ent folder if it is empty

Fixes the permissions to make the java JRE executable

63ed970

Adds a timestamp for the installation/uninstallation/upgrade of NMF P…

61e5fd4

…ackages

Code cleanup

5c97592

Small code improvements

367edc6

Improves the doComputerVision error

c6a6843

Better username lookup from the /etc/passwd file

a8a0c1a

The supervisor will exit if ran as root user

37a1148

Updates on the code to fix the auto rebasing mistakes

6115fde

Fixes the CameraSettings arguments

0268bb2

CesarCoelho force-pushed the phi-sat-2 branch from 871b4f9 to 0268bb2 Compare February 23, 2023 16:21

CesarCoelho and others added 9 commits February 24, 2023 11:39

Removes the mo_pic from CTT and the Beans dependency

c5751e4

Adds Exit Codes to the cli-tool & Fixes the start/stop/kill by gettin…

5e69f79

…g the App Ids directly from the Apps Launcher service instead of getting it from the COM Archive

Code cleanup

8f8ec63

Adds progress messages and ups the version of the picocli library

67cb515

Refactors the code and adds a first class with the Package Management…

8f5b99c

… commands

Adds install, uninstall, and upgrade functionalities to the cli-tool

b1a883c

[CLI] Updated software management commands

dc45ee6

Refactors the cli-tool and add the Action service

2108d16

[CLI] Updated software management commands, added command to set appl…

0aca9b9

…ication parameter

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phi sat 2 #103

Phi sat 2 #103

CesarCoelho commented Aug 19, 2021

dmarszk left a comment

dmarszk Aug 30, 2021

CesarCoelho Nov 3, 2021

dmarszk Dec 6, 2021

dmarszk Aug 30, 2021

CesarCoelho Nov 3, 2021

dmarszk Dec 6, 2021

dmarszk commented Aug 30, 2021

dmarszk Dec 6, 2021 •

edited

Loading

dmarszk commented Dec 6, 2021

dmarszk Sep 23, 2022

CesarCoelho Sep 23, 2022

Phi sat 2 #103

Are you sure you want to change the base?

Phi sat 2 #103

Conversation

CesarCoelho commented Aug 19, 2021

dmarszk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmarszk commented Aug 30, 2021

dmarszk Dec 6, 2021 • edited Loading

Choose a reason for hiding this comment

dmarszk commented Dec 6, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmarszk Dec 6, 2021 •

edited

Loading