*fix bug: Error in Base implementation of class SynetDeconvolution16b…

…NhwcGemm.
ermig1979 · Oct 3, 2024 · 739d076 · 739d076
1 parent 9699a32
commit 739d076
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/docs/2024.html b/docs/2024.html
@@ -41,6 +41,10 @@ <h5>Improving</h5>
 <ul>
  <li>AVX-512BW optimizations of function Convolution32fNhwcDepthwiseDefault.</li>
 </ul>
+<h5>Bug fixing</h5>
+<ul>
+ <li>Error in Base implementation of class SynetDeconvolution16bNhwcGemm.</li>
+</ul>
 
 <a href="#HOME">Home</a>
 <hr/>

diff --git a/src/Simd/SimdBaseSynetDeconvolution16bNhwcGemm.cpp b/src/Simd/SimdBaseSynetDeconvolution16bNhwcGemm.cpp
@@ -57,7 +57,7 @@ namespace Simd
             return size;
         }
 
-        void SynetDeconvolution16bNhwcGemm::SetAlgParam(size_t F, size_t microM, size_t microN, size_t microK, size_t L1, size_t L2, size_t L3)
+        void SynetDeconvolution16bNhwcGemm::SetAlgParam(size_t F, size_t microN, size_t microM, size_t microK, size_t L1, size_t L2, size_t L3)
         {
             const DeconvParam& p = _param;
             AlgParam& a = _alg;

diff --git a/src/Simd/SimdSynetDeconvolution16b.h b/src/Simd/SimdSynetDeconvolution16b.h
@@ -147,7 +147,7 @@ namespace Simd
             typedef void(*BiasActPtr)(const float* src, const DeconvParam& p, const AlgParam& a, size_t dstC, size_t yBeg, size_t yEnd, const float* bias, const float* params, uint8_t* dst);
 
         protected:
-            void SetAlgParam(size_t F, size_t microD, size_t microN, size_t microK, size_t L1, size_t L2, size_t L3);
+            void SetAlgParam(size_t F, size_t microN, size_t microM, size_t microK, size_t L1, size_t L2, size_t L3);
             void ForwardCommon(const uint8_t* src, uint16_t* bufS, float* bufB, float* bufD, uint8_t* dst);
             void GemmCommon(const uint16_t* src, float* dst);
 

diff --git a/src/Test/TestSynetDeconvolution16b.cpp b/src/Test/TestSynetDeconvolution16b.cpp
@@ -195,8 +195,8 @@ namespace Test
 #endif
 #else
 #if 1
-        //result = result && SynetDeconvolution16bForwardAutoTest(eps, Param(1, 720, 192, 256, 64, _4, _1, _2, _1, _1, 1, aId, tF, f32, f32), c, f1, f2);
-        result = result && SynetDeconvolution16bForwardAutoTest(eps, Param(1, 24, 12, 16, 32, _2, _1, _1, _1, _1, 1, aId, tT, f32, f32), c, f1, f2);
+        result = result && SynetDeconvolution16bForwardAutoTest(eps, Param(1, 720, 192, 256, 64, _4, _1, _2, _1, _1, 1, aId, tT, f32, f32), c, f1, f2);
+        //result = result && SynetDeconvolution16bForwardAutoTest(eps, Param(1, 24, 12, 16, 32, _2, _1, _1, _1, _1, 1, aId, tT, f32, f32), c, f1, f2);
 #endif
 #endif