fix: Change INSTALL_PREFIX placeholder notation to templating notation #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation
The former shell notation `$INSTALL_PREFIX` could result confusing. As
this is a placeholder that's replaced in the `make`, we switch it to a
template notation `{{ INSTALL_PREFIX }}`.
|
Most of the changes are a massive replace of EDIT: |
gerardbosch
commented
Dec 12, 2023
gerardbosch
commented
Dec 12, 2023
erikw
reviewed
Dec 13, 2023
erikw
reviewed
Dec 13, 2023
co-authored-by: giuaig <[email protected]>
gerardbosch
force-pushed
the
fix/prefix-template
branch
from
3f6f3a2
to
36e2431
Compare
Co-authored-by: Gerard Bosch <[email protected]>
gerardbosch
added a commit
to gerardbosch/restic-automatic-backup-scheduler
that referenced
this pull request
Dec 14, 2023
erikw#131) * refactor: Change INSTALL_PREFIX placeholder notation to templating notation The former shell notation `$INSTALL_PREFIX` could result confusing. As this is a placeholder that's replaced in the `make`, we switch it to a template notation `{{ INSTALL_PREFIX }}`. * docs: Small fix on README/manual setup * docs(email-notif): Document the `{{ INSTALL_PREFIX }}` placeholder co-authored-by: giuaig <[email protected]> * Update README.md Co-authored-by: Gerard Bosch <[email protected]> --------- Co-authored-by: giuaig <[email protected]> Co-authored-by: Erik Westrup <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former shell notation
$INSTALL_PREFIXcould result confusing. Asthis is a placeholder that's replaced by
make, we switch it to atemplate notation
{{ INSTALL_PREFIX }}.Also, fixes one occurrence of the placeholder in
restic_backup.shnot replaced (was using${}notation and not replaced bysed).