rpcdaemon: generate transaction receipts on-the-fly #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupin012
force-pushed
the
generate_receipt
branch
from
ba913f8
to
8a9aaee
Compare
lupin012
force-pushed
the
generate_receipt
branch
from
327803f
to
ec7c8bf
Compare
canepat
changed the title
canepat
approved these changes
Oct 1, 2024
| executor.reset(); | ||
| } | ||
| return rpc_receipts; | ||
| }); |
There was a problem hiding this comment.
We should be able to parallelise the generation of the receipts by scheduling the execution of each transactions as a separate async_task, as opposed to having just one. This will require setting up dedicated history State instances for each txn_num.
lupin012
force-pushed
the
generate_receipt
branch
from
ca943c9
to
7e5c6e2
Compare
canepat
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generation on-the-fly for transaction receipts if not present on the data storage.
EVMExecutor::call_with_receiptsis currently copy-paste ofEVMExecutor::call, waiting for the work in #2364 to be merged, then a refactoring will be needed