Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-2540 Import LAS - Depth Logs #2541

Merged
merged 5 commits into from
Sep 3, 2024
Merged

FIX-2540 Import LAS - Depth Logs #2541

merged 5 commits into from
Sep 3, 2024

Conversation

eliasbruvik
Copy link
Contributor

@eliasbruvik eliasbruvik commented Sep 3, 2024 •
edited
Loading

Fixes

This pull request fixes #2540

Description

Added logic to parse LAS files.
This implementation does not parse the index curve of time logs, which is needed to import most LAS time logs.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Desktop
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

robertbasti
robertbasti approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@robertbasti robertbasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the code and tested, seems ok

@eliasbruvik eliasbruvik merged commit bf5d04d into equinor:main Sep 3, 2024
4 checks passed
@eliasbruvik eliasbruvik deleted the FIX-2540-LAS-Depth branch September 3, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbasti robertbasti robertbasti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import LAS files - Depth logs
2 participants
@eliasbruvik @robertbasti