Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api.Workers tests #1907 #2523

Merged
merged 16 commits into from
Aug 23, 2024
Merged

Api.Workers tests #1907 #2523

merged 16 commits into from
Aug 23, 2024

Conversation

robertbasti
Copy link
Collaborator

@robertbasti robertbasti commented Aug 16, 2024 •
edited
Loading

Fixes

This pull request fixes #1907

Description

Added more unit tests covering workers.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Desktop
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@robertbasti robertbasti marked this pull request as draft August 16, 2024 10:47
@robertbasti robertbasti added the Blocked Requires other issues to be fixed first label Aug 16, 2024
@robertbasti robertbasti removed the Blocked Requires other issues to be fixed first label Aug 21, 2024
@robertbasti robertbasti marked this pull request as ready for review August 21, 2024 06:46
eliasbruvik
eliasbruvik approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer checklist

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@robertbasti robertbasti merged commit f6d3133 into equinor:main Aug 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasbruvik eliasbruvik eliasbruvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Api.Workers tests
2 participants
@robertbasti @eliasbruvik