Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced query logger for witsml client #1978

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Enhanced query logger for witsml client #1978

merged 3 commits into from
Aug 3, 2023

Conversation

oleksiishv
Copy link
Contributor

@oleksiishv oleksiishv commented Jul 26, 2023 •
edited
Loading

Description

Added more parameters to the custom logger interface. This change will allow to creation of more advanced logs.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

janburak
janburak approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@janburak janburak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@janburak janburak merged commit 32be3d5 into main Aug 3, 2023
1 check passed
@janburak janburak deleted the enhanced_logger branch August 3, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janburak janburak janburak approved these changes

@lindsve lindsve Awaiting requested review from lindsve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksiishv @janburak