Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-1967 Search by well/wellbore/object properties #1973

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

eliasbruvik
Copy link
Contributor

@eliasbruvik eliasbruvik commented Jun 28, 2023

Fixes

This pull request fixes #1967

Description

  • Created a new API route to search by object type with a specified property.
  • When attempting to fetch an object by a property, it first sends a request to see if the Witsml server supports to select by that property.
  • Added a new exception for unsupported capabilities.
  • Created ObjectSearchResult in API and Frontend that includes a SearchProperty.
  • Added numLicense and ServiceCompany that were missing in some models.
  • Added additional info for search options.
  • Added an optional severity to alerts.
  • Updated filter.tsx to search by well/wellbore/object properties.
  • Added a special IS_EMPTY keyword to search for empty properties of some of the types.
  • Created tests to test new functionality.

How to add new properties to search for:

  • Go to filter.tsx.
  • Look at the enums, find the one that fits your property (ObjectPropertyFilterType if it's a property under an object).
  • Add the values (if necessary for that type) to objectPropertyFilterTypeToObjects and filterTypeToProperty.
  • Edit getFilterTypeInformation for that type if you need a different description.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

Copy link
Contributor

@janburak janburak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@eliasbruvik eliasbruvik merged commit 8c60df5 into equinor:main Jul 4, 2023
2 checks passed
@eliasbruvik eliasbruvik deleted the FIX-1967 branch July 4, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search by well/wellbore/object properties
2 participants