Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default identity transform #77

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Add default identity transform #77

merged 1 commit into from
Aug 9, 2023

Conversation

Afonso-2403
Copy link
Contributor

  • Rename the existing transform to Klab
  • Add identity transform (same regardless of robot frame or asset frame) as the default one

@Afonso-2403 Afonso-2403 added the improvement Improvement to existing functionality label Aug 9, 2023
@Afonso-2403 Afonso-2403 self-assigned this Aug 9, 2023
andchiind
andchiind approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, already partially tested

src/isar_exr/config/maps/exr_default.json Outdated Show resolved Hide resolved
@Afonso-2403 Afonso-2403 merged commit ba2f7dc into equinor:main Aug 9, 2023
2 checks passed
@Afonso-2403 Afonso-2403 deleted the add-default-transform branch August 9, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees

@Afonso-2403 Afonso-2403

Labels
improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Afonso-2403 @andchiind