Improve general stability #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andchiind
force-pushed
the
improve-stability
branch
2 times, most recently
from
d7eebff
to
cdfa4d7
Compare
andchiind
force-pushed
the
improve-stability
branch
from
cdfa4d7
to
82899ca
Compare
Christdej
requested changes
Apr 17, 2024
src/isar_exr/robotinterface.py
Outdated
| @@ -216,6 +216,8 @@ def initiate_mission(self, mission: Mission) -> None: | |||
| mission_definition_id=mission_definition_id, robot_id=settings.ROBOT_EXR_ID | |||
| ) | |||
|
|
|||
| time.sleep(5) | |||
There was a problem hiding this comment.
Maybe add comment to why there is a sleep here?
There was a problem hiding this comment.
With more testing it seems like it is no longer neccessary after I increased the HTTP timeout, so I've removed it
andchiind
force-pushed
the
improve-stability
branch
3 times, most recently
from
91c8ad8
to
5ab896a
Compare
Christdej
approved these changes
Apr 18, 2024
Handle a new authentication response. Increase energy robotics API timeout. Handle null values when fetching battery status. Handle duplicate custom tags. Handle getting step status before mission starts.
andchiind
force-pushed
the
improve-stability
branch
from
5ab896a
to
9a917fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.