Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement alert list feature #1713

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Implement alert list feature #1713

merged 3 commits into from
Aug 29, 2024

Conversation

haakonsf
Copy link
Contributor

@haakonsf haakonsf commented Aug 8, 2024 •
edited
Loading

First PR for #1560. Further design and functionalities should be discussed in UX meeting

@haakonsf haakonsf force-pushed the 1560-implement-alert-feature branch 4 times, most recently from f92e3f8 to 87879ed Compare August 20, 2024 11:34
@haakonsf haakonsf marked this pull request as ready for review August 20, 2024 12:06
@haakonsf haakonsf added frontend Frontend related functionality feature New feature or request labels Aug 20, 2024
betaniat
betaniat reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@betaniat betaniat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Screenshot 2024-08-21 at 10 23 18 AM

Alerts displayed, and queue mission button working as expected.

@Eddasol
Copy link
Contributor

Eddasol commented Aug 21, 2024

Need to clean up commit history

@haakonsf haakonsf force-pushed the 1560-implement-alert-feature branch 2 times, most recently from 15e7781 to eee0363 Compare August 26, 2024 07:36
@haakonsf haakonsf force-pushed the 1560-implement-alert-feature branch from eee0363 to 2658189 Compare August 26, 2024 08:09
Eddasol
Eddasol reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@Eddasol Eddasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of how much duplicated code there is, but ok as a first iteration of the alert feature

frontend/src/components/Alerts/AlertsListItem.tsx Outdated Show resolved Hide resolved
frontend/src/components/Alerts/AlertsListItem.tsx Outdated Show resolved Hide resolved
@haakonsf haakonsf force-pushed the 1560-implement-alert-feature branch from 2658189 to d7d7fbd Compare August 26, 2024 09:05
@haakonsf haakonsf force-pushed the 1560-implement-alert-feature branch from d7d7fbd to f5d6eb4 Compare August 26, 2024 09:51
@haakonsf haakonsf mentioned this pull request Aug 15, 2024
Open
22 tasks
@haakonsf haakonsf merged commit 9fe5ab6 into equinor:main Aug 29, 2024
10 checks passed
@haakonsf haakonsf deleted the 1560-implement-alert-feature branch August 29, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betaniat betaniat betaniat left review comments

@Eddasol Eddasol Eddasol approved these changes

Assignees
No one assigned
Labels
feature New feature or request frontend Frontend related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haakonsf @Eddasol @betaniat