🐛 Fix crash when empty parameters in request

Jenkinsfile

@@ -6,7 +6,7 @@ pipeline {
         PUBLIC_KEY = credentials('EPITECH_SSH_PUBKEY')
         GHCR_TOKEN = credentials('github-packages-token')
         IMAGE_NAME = 'epitech-mirroring/rountable-server'
-        IMAGE_VERSION = '1.02.8'
+        IMAGE_VERSION = '1.02.9'
         MIRROR_URL = '[email protected]:EpitechPromo2027/B-NWP-400-NAN-4-1-myteams-marius.pain.git'
     }
     stages {

common/network/src/dto/request.c

@@ -34,12 +34,15 @@ static char *parse_param(request_t *req, char *param)
     regex_t regex;
     regmatch_t matches[3];
 
-    regcomp(&regex, "([^=]+)=([^&]+)", REG_EXTENDED);
+    regcomp(&regex, "([^=]+)=?([^&]+)?", REG_EXTENDED);
     if (regexec(&regex, param, 3, matches, 0) == 0) {
         key = strndup(param + matches[1].rm_so,
             matches[1].rm_eo - matches[1].rm_so);
-        value = strndup(param + matches[2].rm_so,
-            matches[2].rm_eo - matches[2].rm_so);
+        if (matches[2].rm_so != -1)
+            value = strndup(param + matches[2].rm_so,
+                matches[2].rm_eo - matches[2].rm_so);
+        if (value == NULL)
+            value = strdup("");
     }
     regfree(&regex);
     request_add_param(req, key, value);

server/src/clients/composables.c

@@ -88,6 +88,8 @@ roundtable_client_instance_t *get_instance_from_header(
     if (header == NULL)
         return NULL;
     uuid_str = strndup(header + strlen("Bearer "), 32);
+    if (strlen(header) < strlen("Bearer ") + 32 + 2)
+        return NULL;
     instance_str = header + strlen("Bearer ") + 32 + 1;
     instance = get_instance_from_strings(server, uuid_str, instance_str);
     free(uuid_str);

server/src/routes/teams/channels/threads/create.c

@@ -69,7 +69,7 @@ static response_t create_thread_response(roundtable_channel_t *channel,
 }
 
 static response_t validate_request(request_t *req, roundtable_server_t *srv,
-    roundtable_client_t *client, json_object_t *body)
+    roundtable_client_instance_t *client, json_object_t *body)
 {
     roundtable_team_t *team = get_team_from_json(srv, body, "team_uuid");
     roundtable_channel_t *channel = NULL;
@@ -80,13 +80,13 @@ static response_t validate_request(request_t *req, roundtable_server_t *srv,
         return create_error(401, "Unauthorized", "Invalid 'Authorization'");
     if (!team)
         return create_error(404, "Team not found", "Team not found");
-    if (!roundtable_team_has_subscriber(team, client))
+    if (!roundtable_team_has_subscriber(team, client->client))
         return create_error(403, "Forbidden", "Client not a subscriber");
     channel = get_channel_from_json(team, body,
     "channel_uuid");
     if (!channel)
         return create_error(404, "Channel not found", "Channel not found");
-    return create_thread_response(channel, body, client);
+    return create_thread_response(channel, body, client->client);
 }
 
 response_t create_thread_route(request_t *request, void *data)
@@ -100,5 +100,5 @@ response_t create_thread_route(request_t *request, void *data)
         return create_error(405, "Method not allowed", "Only POST");
     if (!body || !body_is_valid(body))
         return create_error(400, "Invalid body", get_missing_key(body));
-    return validate_request(request, server, instance->client, body);
+    return validate_request(request, server, instance, body);
 }