Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(help): improve description for CLI flags #31

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix(help): improve description for CLI flags #31

merged 1 commit into from
Nov 17, 2023

Conversation

jpetazzo
Copy link
Member

@jpetazzo jpetazzo commented Feb 5, 2023

'ignore-namespace` was outright false 😅

It could probably be further improved by mentioning the webhook filtering mechanism.

@paullaffitte
Copy link
Contributor

paullaffitte commented Feb 6, 2023 •
edited
Loading

Actually I was even wondering if we should not remove this flag since there is a feature overlap between it and webhook filtering. Indeed, this flag was introduced (2307855) before we started using webhook filtering (77a2cd4) based on an annotation. We actually even filter out pods from kuik release in 3 different ways since 790b977 where we added webhook filtering based on namespaces.

What do you think?

@paullaffitte paullaffitte mentioned this pull request Feb 6, 2023
Merged
@donch
Copy link
Member

donch commented Feb 6, 2023

I agree, we should not have multiple way to achieve the same things.
BTW, we should consider disable kuik from its own namespace by default (e.g. without using the webhook filter)

@paullaffitte paullaffitte mentioned this pull request Aug 1, 2023
Merged
@paullaffitte
Copy link
Contributor

The --ignore-namespace flag has been removed by #138, could you please update your branch accordingly?

@jpetazzo
fix(help): improve description for CLI flags
a38e5a3 
Minor tweak to clarify what the port number corresponds to
@jpetazzo
Copy link
Member Author

Updated!

@paullaffitte paullaffitte merged commit c5fbf75 into enix:main Nov 17, 2023
13 checks passed
@monkeynator
Copy link
Member

🎉 This PR is included in version 1.5.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@monkeynator
Copy link
Member

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @main released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpetazzo @paullaffitte @donch @monkeynator